Design comparison
SolutionDesign
Solution retrospective
feel free to give me some suggestion.
Community feedback
- @0xabdulPosted over 1 year ago
Hey dude well congrats on completing the NFT card component ..π
- A little suggestion for improve your code ..
- In Html π·οΈ :
- the html page should be contained one main landmark using semantic elements β
- Ex :
<html lang="en"> <head> <title>my page</title> </head> <body> <header> //logo img or heading ect... //Using heading onlyβ </header> <main> //Use only main of the contents </main> <footer> //use copy write discription or challenge d by front end mentor code by mark.. </footer> </body> </html>
- I hope it's useful for
- happy Codding
Marked as helpful0 - @visualdennissPosted over 1 year ago
Looks great overall! I'd suggest not using the opacity on overlay like this, because then the child elements, like the image lose opacity too, which is not what we want here. Instead try to adjust the background opacity by using and hsla value instead of hsl, e.g. background-color: hsla(178, 100%, 50%, 50%); the last value with % is about opacity.
Hope you find this feedback helpful!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord