Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Card No Flexbox

@MichaelSurgeon

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


is there a better way of doing the hover for the image? I never wanted to use flex-box because I wanted to grasp css more and I felt it would be more of a challenge.

Thanks!

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Michael, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • The way you used for the : hover effect is fine, another way is to create a div that appears on hover. I used tailwind but you can see and understand which CSS properties I used and how to do it alternatively. Look here -> my solution
  • if you want to center a div using absolute you don't need the margin but just usetop: 50%, left: 50% and transform: translate (-50%, -50%)
  • but centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • remove all margin from card class
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

1

@MichaelSurgeon

Posted

@denielden Thanks for your feedback!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord