Design comparison
Solution retrospective
Simple card that i made with flexbox and also i use media queries for that the designs become adaptable.
I use flexbox because i use gap instead of margin to separate elements.
Some feedback and advice are welcome.
Community feedback
- @maciejkrol18Posted about 2 years ago
-
I think the card gets slightly too small on lower screen sizes.
-
You've done a good job with applying
aria-hidden
to images that do not need to be read by assistive technology out loud. However, your project still lacks basic accessibility. Remember to use semantic HTML and change thediv
with the class ofcard
to amain
tag - Frontend Mentor's accessibility report points this issue out.
0@EidrianMaxPosted about 2 years agoHello @FancyBaguette thank you for your feedback.
- I understand the card may be a little bit small in lower screen size.
- In regarding with accessibility problems i think isn't necessary for this exercise because the component doesn't need a main tag or h1 tag
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord