Design comparison
Community feedback
- @Sdann26Posted over 2 years ago
Hi Daniel!
This challenge you did quite well with only two details you should have added both the title and the name "Jules Wyvern" should have that effect of being able to change color to one similar to Cyan.
By the way what is pending is to finish resolving the errors in the report for which I can recommend 2 things. Either change
<div id="container">
to<main id="container">``, or change
<div id="card-container">to
<main id="card-container">and
<div class="attribution">to
<footer class="attribution">`.The main reason is that you need to have a <main> that contains the main content of your code. In case two we are assuming that the main content is in the card and the footer is the same attribution.
Also one last change from
<h3>Equilibrium #3429</h3>
to<h1>Equilibrium #3429</h1>
since you need to have one per page.If you want me to go into more detail just ask.
Good Coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord