Nice job on this. The html is good, just make sure you format it so all the code indentation is consistent and neat (easier to read and easier to spot bugs)
Some of the sizes on this look a little off, like the font size on the price and time left, and the cards max width when I view on mobile landscape or view your preview above. One max width in rem on this should be enough, I'm not sure there is any need for a media query on this challenge
Marked as helpful
@Callietron300
Posted
@grace-snow thanks grace, normally I'm good with indentations I must of missed something, I will go through and check!
I was wondering about using rem in my last project thank you, I'll have a play later.
If it's not too much to ask with the font sizes did I do the right thing? I'm still trying to understand what's best practice for setting up default sizes. I will try find an article on it I think
@Callietron300 rather than sizing font size on a wildcard I would set it on the body. Then change other font sizes as needed on elements like the heading, wrapper divs and card footer. Font size would be in rems, just as you've done
Until you've got Pro membership though, font sizes are always going to be guess work. I wouldn't worry about getting them exactly right on practice projects when you don't have access to the design files
Marked as helpful
@Callietron300
Posted
@grace-snow sweet, I set them out side the body and used em on the defaults I think, and had originally used px in my * styling. That's alot it's really appreciated
