Design comparison
Community feedback
- @RadexmanPosted about 2 years ago
Hi there, good job on that project! If you don’t mind, I will provide you with some feedback. So I checked your code and it appears that you used <h2> tag and no <h1>, this is considered a mistake because when using headings we want to stick to the so - called hierarchy. You probably did it because the font size was correct for that text. No worries just add <h1> element and change its styling in css. We typically want to start from h1 and move our way to h6. Here is some good resource on that topic:
https://www.contentkingapp.com/academy/headings/
Also it appears that you added your styles inline. It is cool in small projects like this one but we want to separate our docs from each other eg. index.html, style.css, app.js all three as separate files connected via link and script tags in our html. It helps us keep our code readable and not make too much razmataz with other languages.
Overall great work on that project! I hope I was a little bit helpful for you. Keep going and happy coding!
0@Zubby126Posted about 2 years ago@Radexman this was an old stuff I did and I don't have strength to redo it again. I have new works I separated. Thanks for the review
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord