NFT CARD "create overlay with ::after & ::before"

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  HTML:

  • Try not to use the <main> tag as a component, use it as a container that will wrap the component in question.

  CSS:

  • Try not set a fixed width, use max-width instead (style.css line 20). If you want to limit the shrinking part set a min-width.
  • Let the content define the height of the component itself, you could use padding and margins for the children to achieve this. And of course, the component padding is a must.
  • Try to use CSS Custom Properties to store the project colors

  Marked as helpful

  0

  ---

  

  Gwen-lego•230

  @Gwen-legoPosted over 1 year ago

  hI @AGutierrezR,

  thank you for taking the time to comment on my coding, it helps a lot! I have made the modifications you suggested and it make my life easier now.

  Thanks have a good one.

  0