Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT CARD "create overlay with ::after & ::before"

Gwen-lego 190

@Gwen-lego

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


A good challenge that introduced me to pseudo elements. Nearly missed the shadow.

Community feedback

@AGutierrezR

Posted

Hello there 👋. Good job on completing the challenge!

I have some suggestions about your code that might interest you.

HTML:

  • Try not to use the <main> tag as a component, use it as a container that will wrap the component in question.

CSS:

  • Try not set a fixed width, use max-width instead (style.css line 20). If you want to limit the shrinking part set a min-width.
  • Let the content define the height of the component itself, you could use padding and margins for the children to achieve this. And of course, the component padding is a must.
  • Try to use CSS Custom Properties to store the project colors

Marked as helpful

0

Gwen-lego 190

@Gwen-lego

Posted

hI @AGutierrezR,

thank you for taking the time to comment on my coding, it helps a lot! I have made the modifications you suggested and it make my life easier now.

Thanks have a good one.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord