NFT Card Component with sass

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted almost 3 years ago

  1- You've simulated the behavior of link using a span, why not use a link in first place which make much more easier for other users as well. A big disadvantage with this approach is that you can not similate the bahavior of link when read be screen readers.

  2- The alt attribute of the image used for hover state has no meaning because the screen reader user can not see the hover state, the coin icon alternative text is also redundant because it does not add and additional information. There no difference in hearing "0.041 ETH" and "coin 0.041ETH" because the bit "ETH" already implies that its currency.

  Keep coding :=)

  Marked as helpful

  1

  ---

  

  Abhishek Rawat•40

  @rawatdevPosted almost 3 years ago

  @MojtabaMosavi

  Thankyou so much for reply

  1. Update the span to anchor tag.

  2. I have changed the ETH image alt from coin to ETH only. I have seen in crypto websites what alt text they use.

  0

  

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted almost 3 years ago

  @rawatdev Nice Job.

  0