Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Evandro, great work on this challenge! π
Here are a few tips for improve your code:
- first, remove
width and height
fromcontainer
class - add
main
tag and wrap the card for improve the Accessibility img
element must have analt
attribute, it's very important! add it to author image- You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of element like.text-area
class - centering a
div
withabsolute or relative
positioning is now deprecated, it uses modern css likeflexbox or grid
- use flexbox to
container
class to center the card. Read here -> best flex guide - after, add
min-height: 100vh
tocontainer
class because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well π Hope this help!
Marked as helpful1@evandromarisPosted over 2 years ago@denielden thanks for the tips, I will study flexbox.
1 - first, remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord