Design comparison
SolutionDesign
Solution retrospective
Any suggestions or feedback on how I can improve my code are most welcome!
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi there! 👋
Good effort on this challenge! 👍
Two (or more) things can be done better.
- Alternative text for images should not contain any words that are related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image. Also, it should not be hyphenated (like code).
- All the icons are decorative images. So, leave the
alt=""
empty. - There should not be text in
span
anddiv
alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.
That's it! Hope you find this useful!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord