NFT card component using flexbox

Community feedback

• 

  Sinisa Vukmirovic•1,690

  @SinisaVukmirovicPosted almost 2 years ago

  Hello.

  Your MarkUp (HTML) structure could be improved.

  You are not using HTML5 semantic elements in your mark down. I understand your just started learning, but... better to start sooner than later. More about semantic elements - https://developer.mozilla.org/en-US/docs/Glossary/Semantics

  Warning in your reports are, mostly, about that... lack of semantics structure. That's what they mean by landmark - "Document should have one main landmark". Landmark means <main></main> HTML5 element.

  "Page should contain a level-one heading", Level-one heading means you are missing <h1></h1> element in your page semantics structure.

  This "All page content should be contained by landmarks" means that everything on a page should be inside of those semantic elements from the link I provided. No divs in body that are outside of those semantic elements.

  Hope this was understandable and that it helps!

  1

  ---

  

  Arash Kazerouni•140

  @arashKazerouniPosted almost 2 years ago

  @SinisaVukmirovic thanks for this great helpful answer, i will resolve this challenge and I will consider the points you said. thank you so much for giving me your time

  0
• 

  José Vásquez•10

  @JoseevbPosted almost 2 years ago

  Hi Arash! Your project looks really good! There are some things that you could improve on: putting all elements of the card (image, description and footer) in an <article> tag could help improve the semantics of a page; there's also the spacing between the elements and the size of the image that don't match exactly the ones on the design (there are pretty difficult to match without the exact values, so I understand that disparity). Other than that, it looks really good! I look forward to seeing more designs.

  1

  ---

  

  Arash Kazerouni•140

  @arashKazerouniPosted almost 2 years ago

  @Joseevb Hi! thank you so much, i will work and study more on semantic html

  0