Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Marvin, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - add descriptive text in the
alt
attribute of the image - You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - use
h1
for the title of card instead a simplep
- add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful1 - add
- @escarcanPosted over 2 years ago
Hola Marvin, buen trabajo! para solucionar tus 6 errores de accesibilidad recuerda envolver tu codigo HTML en una etiqueta <main>, y ten al menos un <h1> para que no te de errores en el reporte.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord