NFT Card Component Solution Using Flexbox

Community feedback

• 

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  Hey @anoshaahmed,

  Great job on your first design!

  I checked your other solution too and I saw that you improved tremendously from one design to another so really good job on that!

  I would encourage you to use not just colors in your :root selector but also font size, font family, font weights etc. The idea of having CSS custom properties or variables is to keep everything in one place for cleaner code and easy changes. This might not make so much sense as of now on such small projects, but when you work in big projects this is a must.

  I would also encourage you to take a step away from using pixels for margins, font sizes etc. Pixels don't allow for smooth responsiveness and will lock stuff in place.

  Here are some great tutorials on the different types of units:

  • Are you using the right CSS units?
  • CSS em and rem explained

  FYI I took inspiration from your design for the image overlay so good job on that!

  Hope this helps! Great start and just keep on coding! :)

  Marked as helpful

  2

  ---

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @NomiDomi I appreciate you so much for going over my code and for your helpful feedback!!! I would definitely learn to utilize custom CSS properties, and other forms of units in my future projects. Thank you!

  1
• Account deleted

  Acho que o html poderia ficar melhor, mas resultado esta ótimo, fiz o meu com preguiça.

  Marked as helpful

  0

  ---

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @Anderson-Medeiros I agree. This is the first project I did by myself so I aim to get better at organizing my HTML. Thank you.

  0
• 

  Anton Sukhadolets•330

  @SuhodolecAPosted almost 3 years ago

  Nice work!

  1

  ---

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @SuhodolecA thank u c:

  0
• 

  Brandon•60

  @walker861Posted almost 3 years ago

  Thanks for participating Anosha! I am new on my coding journey so I'm only able to speak from my extremely limited experience. Once I had a majority of my solution coded, I found yours on the slack channel. As a newbie, I felt I understood your code fairly easily.

  It helped me figure out how to do the hover states. I have been using The Odin Project but have not been exposed to use of the hover property. So that was extremely helpful. Thanks for posting! Happy coding!

  1

  ---

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @walker861 I'm really happy you found my code useful! Thank you so much for your kind feedback! :) Happy codingggg

  0
• 

  roastgrammer•60

  @roastgrammerPosted almost 3 years ago

  I think this is very nice for your first project and you did it well ! be happy:)

  1

  ---

  Account deleted

  @roastgrammer tankyou

  0

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @roastgrammer thank u i appreciate that

  0