NFT card component made with basic HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Ayush, great job!

  • try to use flexbox to the body for center the card. Read here -> flex guide
  • remove all margin from box because with flex they are superfluous.
  • after set heigth of body to 100vh because Flexbox aligns to the size of the parent container.
  • add main tag and wrap the card for Accessibility
  • Also instead of using px try to use relative units of measurement -> read here

  Overall you did well! Hope this help ;)

  Marked as helpful

  0

  ---

  

  Ayush•30

  @Ayush1MPosted almost 3 years ago

  @denielden Thank you so much for your valuable suggestion. Well I have not thought of using flexbox but after looking back at my code you are right it will be much easy. And now I get that I have to set the height of body to vh to properly size it. These suggestions will really help me to improve.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @Ayush1M I am happy that they are helpful to you :) Keep it up !

  1
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • Always Use Semantic HTML instead of div like <main> <header> , etc for more info

  • Give The body these properties to center the element display:flex justifiy-content:center align items: center min-height:100vh

  if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  0

  ---

  

  Ayush•30

  @Ayush1MPosted almost 3 years ago

  @Old1337 Thank you for your valuable suggestion. I will keep this in mind next time.

  1