@denielden
Posted
Hi Ayush, great job!
- try to use flexbox to the body for center the card. Read here -> flex guide
- remove all
margin
frombox
because with flex they are superfluous. - after set
heigth
of body to100vh
because Flexbox aligns to the size of the parent container. - add
main
tag and wrap the card for Accessibility - Also instead of using
px
try to use relative units of measurement -> read here
Overall you did well! Hope this help ;)
Marked as helpful
@Ayush1M
Posted
@denielden Thank you so much for your valuable suggestion. Well I have not thought of using flexbox but after looking back at my code you are right it will be much easy. And now I get that I have to set the height of body to vh to properly size it. These suggestions will really help me to improve.
@denielden
Posted
@Ayush1M I am happy that they are helpful to you :) Keep it up !