NFT Card Component challenge with some experiencing

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this project. Looking at your solution, I would like to suggest the following for you…

  • Import the attribution style in CSS file and remove the style tag
  • Include description with the alt in image tags. Like this line <img class="eq-main" src="./images/image-equilibrium.jpg" alt="">
  • Wrap the whole content attribution with footer tag. For HTML structures, refer it with this one Semantics
  • Add the hover state of the fonts in .name and span rule sets
  • Clean the whitespaces in the code

  Above all, the design is well implemented. Keep it up and Hope this is helpful!

  Marked as helpful

  2

  ---

  

  Gomes Martins•60

  @gomesemogPosted almost 3 years ago

  @RioCantre thanks for the tips!

  1
• 

  Szczepan•50

  @bczbczPosted almost 3 years ago

  Hi there. Good job. There is some problem with horizontal scrolling in lower resolutions. Check it if you want to improve your solution. Keep going :)

  Marked as helpful

  1

  ---

  

  Gomes Martins•60

  @gomesemogPosted almost 3 years ago

  @bczbcz thanks for the feedback my brother. You got me thinking and i just found where i was wrong on my code. nice!

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! GUILHERME Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Always use h1 first and then h2, h3 and so on

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1

  ---

  

  Gomes Martins•60

  @gomesemogPosted almost 3 years ago

  @Crazimonk thanks, gonna look up to it

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man.

  0