Submitted over 2 years ago

NFT Card Component

Juan Cruz Ardanaz• 230

@juanardanaz

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

NFT preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hi! This is my solution for the "NFT preview card component" challenge. I hope you find it useful and I am open to hearing suggestions/criticisms!

Community feedback

Travolgi 🍕• 31,420

@denielden

Posted over 2 years ago

Hi Juan, I took some time to look at your solution and you did a great job!

Also I have some tips for improving your code:

add main tag and wrap the card for Accessibility
remove top and margin from main_container class
try to use flexbox to the body for center the card. Read here -> best flex guide
after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

Overall you did well :)

Hope this help and happy coding!

Marked as helpful

Juan Cruz Ardanaz• 230

@juanardanaz

Posted over 2 years ago

Hi @denielden! Thank you very much for your feedback and help! I take note of the tips, and I will apply them.

Thanks for the positive response!

Naveen Gumaste• 10,460

@NaveenGumaste

Posted over 2 years ago

Hello Juan ! Congo 👏 on completing this challenge

Let's look at some of your issues, shall we:

Use the flex on the "Eth" and "3 days left"
use the given font-weight and font-style from the style-guide.md
And reduce the opacity of the bottom line
Warp your card content around the main tag Ex: 👇

<body>
<main class="container">
*all you content here*
</main>
</body>

happy Coding😀

Marked as helpful

Juan Cruz Ardanaz• 230

@juanardanaz

Posted over 2 years ago

Hi @Crazimonk! Thank you very much for your feedback! That´s interesting, I´ll try it and see how it works.

Happy Coding too!

IRVINE MESA• 1,855

@DrMESAZIM

Posted over 2 years ago

@juanardanaz that's great work .I will call it perfect solution

Marked as helpful

Juan Cruz Ardanaz• 230

@juanardanaz

Posted over 2 years ago

Hi @DrMESAZIM! Thank you very much for your words, I really value it a lot.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord