NFT Card Challenge using Flexbox

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello FedericoSpina1,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  1. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
     1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>. For the same reason , you can use <a> to wrap Equilibrium #3429.

  2. The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  3. look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  4. To use more semantic tags , you may use <figure> and <figcaption> for the avatar's part.

  5. The alternate text of the avatar image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  6. For middle part of the card class="cost_days flex align-center", you can use an unordered list <ul>, in each <li> there should be <img> and <p> that way you can align them centrally.

  There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • I would not use <section> just for part of the component as <section> is a generic standalone section of a document

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Overall, Your solution is good. Hopefully this feedback helps.

  0

  ---

  

  FedericoSpina1•60

  @FedericoSpina1Posted about 2 years ago

  @PhoenixDev22 Hi thank you for the feedback.

  What I wanted to do with the image was to be able to click it and get a popup zoom but i couldn't figure out how to do it.

  I left the alt text blank because I didn't want to 😂.

  For the <ul> i actually don't know what you are talking about 🤔.

  The idea was actually to use ::before and ::after but i don't know why they don't display with an image.

  What can i use instead of <section>?

  Thank for the rel advice, i didn't know what "noopener" and "noreferrer" were.

  0