Design comparison
SolutionDesign
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Freivys, It looks good!...
My suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main> <div class="card-container card"> //... </div> </main>
- I also suggest you center the component on the page with
Flexbox
, by giving the parent element<main>
the following properties:
main { display: flex; justify-content: center; align-items: center; min-height: 100vh; }
I hope this is helpful to you... Keep coding👍
0@FreivysDevPosted over 2 years ago@Bayoumi-dev Thanks for the suggestions, I'll apply those changes to the code. I will continue practicing and reviewing the good programming practices that must be applied. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord