NFT card

Community feedback

• 

  Adriano•38,160

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Ric, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To remove the scrollbar we can do this:

  body {
      margin: 0;
      padding: 0;
  }
  

  to facilitate the development of a project like this, prefer to use max-width than width!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Ric•210

  @Ripra87Posted almost 2 years ago

  @AdrianoEscarabote Thank you Adriano, your tips and suggestion are always really well accepted! I'll start to use max-width a well )

  1
• 

  Aatypic•490

  @AatypicPosted almost 2 years ago

  Hello and congratulations on your solution !

  I don't understand what you're trying to achieve with your 1st question. Sorry ^^

  For the 2nd question, you need to add a layer inside your <div class="image">, you could create an empty <div class="layer"> and then play with it to match the original. There is a guide on https://www.w3schools.com/howto/howto_css_image_overlay.asp.

  Be careful with the semantic, others here would also say that you should respect the semantic tags. In your case only ONE <section> would be good. Knowing that what we are building is ONE component.

  Oh and also you have a little scroll issue ;)

  Hope it helped, good luck ✌️

  Marked as helpful

  0
• 

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  Hi Ric, in regards to your first question about getting real round borders to HTML elements, are you talking about making a 360-degree circle? If so border-radius: 50%; will turn all elements into a circle, regardless of size. At least, as long as the height and width of the target are the same, otherwise, it will turn into an oval. Alternatively, you can use clip-path: circle(); to turn an element into a circle as well. For example-

  element {
      height: 2rem;
      width: 2rem;
      border-radius: 50%
  }
  

  I hope this is helpful and if so please mark it as helpful : )

  0

  ---

  

  Ric•210

  @Ripra87Posted almost 2 years ago

  @Eileenpk Hi Eileen and thanks for your feedback ) btw, is not exactly what i mean, is hard to explain ) if check to the round borders of the original progect, the main design and compare with mines, my round borders are not completely round, my round borders always end with kind of "cut" in the top (for top borders) and on the bottom that creates a small angle, i was trying to upload a screenshot of the detail but it seems is not possible in the comments ) Update: i found the way to fix the borders ) the problem was i use the % in the border radius, i changed with px instead and now it works )

  0