Rio Cantre• 9,690
@RioCantre
Posted
Hello there! Good job in completing this challenge. Regarding your solution, I would like you to notice the following…
- Instead of
div
, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. Like this line<div class="outer">
can be wrap withmain
tag, this<div class="title">Equilibrium #3429</div>
witha
tag since it has a hover state. - Import the
attribution
style in CSS file and remove thestyle
tag - Instead of using root variables, create a new file for variables and use the Sass syntax in naming the properties like from
--soft-blue: hsl(215,51%,70%);
into$soft-blue: hsl(215,51%,70%);
In the brighter side...
- Well done with the hover state of the design, specially the overlay of the hero image
- Great job in utilizing Sass for styling this project. The compositions are looking great
- The HTML file is clean and readable
- The project is responsive and utilized the details according to the original design
- Proper alignment and sizing elements
Above all, the project is done well. Keep up the good work! Cheers!
Marked as helpful
1
PaulGabriel• 50
@PaulGabriel
Posted
@RioCantre Thank you a lot for the feedback!
0