Design comparison
Solution retrospective
Wondering if the part with hovering over the main image was done okay or if there's a shorter/better way to do it.
Also wondering about any redundant values I specified anywhere.
Community feedback
- @visualdennissPosted over 1 year ago
Hello Ferdi,
good work with the NFT Card!
Hovering seems fine, just the border-radius of the overlay and the image does not match. Image has border-radius: 10px; while overlay has border-radius: 20px; so you might consider syncing them. Also if u want you can add some smooth transition to overlay like transition: all .4s ease;
Also you don't need this: height: 66vh; in fact avoid fixed heights as much as possible. min-height is fine.
Hope you find this feedback helpful!
Marked as helpful1@ferditondeurPosted over 1 year ago@visualdenniss Thank you!
Yeah, I literally just noticed that about the border radius. Must've been an old value I forgot to change haha.
Thanks for the suggestion about the transition and the min-height. Still an old habit I guess. Thanks again!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord