Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

nft-card

@mohammedreddah

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

hi everyone!!

1\ I faced a problem in positioning the marker of " li " elements, although i searched a lot still i didn't find a solution .

2\ In active state exactly in the picture , i have positioned the eye picture using position : fixed ; & top : 14%; my question is: is there a better way & more Professional ?

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! āœ…

Your solution is really impressive!

I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

šŸ“Œ First: Think about using <main> to wrap your main content instead of <div>.

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

šŸ“Œ Second: Don't skip heading levels ā€“ start with <h1>, then use <h2>, and so on.

It's more than just text size ā€” it's about structuring your content effectively:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page ā€“ it should be the main title for the whole page.

These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!

Marked as helpful

1

@mohammedreddah

Posted

@danielmrz-dev Hey Daniel

thanks for the advise i'll try to improve my html structure skills.

thank you so much again.

1
OmarRefaeeā€¢ 200

@OmarRefaee

Posted

Hi Mohammed,

The solution for the first problem which is positioning of marker of li elements you should use list-style-position css property, but it will still not well positioned, so what i did in my solution is to use the icon as svg or img and give the parent container display flex so i can position them well.

The solution for the active state eye picture is to use it in ::before selector with opacity 0 when hover change the opacity.

and that's it good luck in the next project.

Marked as helpful

1

@mohammedreddah

Posted

@OmarRefaee Thanks Omar, I will take a look on your solution so I can learn & understand more. Thank you so much again.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord