nft-card

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 4 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution is really impressive!

  I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

  📌 First: Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  📌 Second: Don't skip heading levels – start with <h1>, then use <h2>, and so on.

  It's more than just text size — it's about structuring your content effectively:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page – it should be the main title for the whole page.

  These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  Marked as helpful

  1

  ---

  

  mohammedreddah•50

  @mohammedreddahPosted 4 months ago

  @danielmrz-dev Hey Daniel

  thanks for the advise i'll try to improve my html structure skills.

  thank you so much again.

  1
• 

  OmarRefaee•200

  @OmarRefaeePosted 4 months ago

  Hi Mohammed,

  The solution for the first problem which is positioning of marker of li elements you should use list-style-position css property, but it will still not well positioned, so what i did in my solution is to use the icon as svg or img and give the parent container display flex so i can position them well.

  The solution for the active state eye picture is to use it in ::before selector with opacity 0 when hover change the opacity.

  and that's it good luck in the next project.

  Marked as helpful

  1

  ---

  

  mohammedreddah•50

  @mohammedreddahPosted 4 months ago

  @OmarRefaee Thanks Omar, I will take a look on your solution so I can learn & understand more. Thank you so much again.

  1