Rio Cantre• 9,690
@RioCantre
Posted
Hello there! Great work with this one. Regarding the solution you submitted, I think you should also take notes of the following…
- Change the background color of the hover state into
background-color: var(--eth-font-color);
in#view-img-container
rule set and adjust the opacity with 0.8 - Add
border: 1px solid white;
andborder-radius: 50%;
in the.creater-container img
rule set - Instead of
div
, alternatively wrap the whole content withmain
tag . Use semantic tags, for HTML structures, refer it with this one Semantics - Wrap this line
<div class="main-container">
withmain
tag andfooter
tag with this line<div class="attribution">
- Alternative is to use
a
tag for the font links. - Instead of using
hr
tag, alternative is to add border top on thecreater-container
rule set
Above all, The design looks good. Keep it up!
Marked as helpful
0
Azeem Saifi• 370
@saifion33
Posted
@RioCantre Hi Rio. Thanks for your feedback i'll try to make better my solution
0