NFT Card

Community feedback

• 

  Talha Khalid•200

  @talha-007Posted about 2 years ago

  Thank you Phoenixdev I really really appreciate the review and I will consider these points when programming. It was very helpful

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Talha Khalid,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • You can use <main> landmark to wrap the NFT card and <footer> the attribution. HTML5 landmark elements are used to improve navigation.

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • The link wrapping the equilibrium image (image-equilibrium ) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • Proper use of labels with the elements (input , meter, progress, ...) not <img> will benefit screen readers. You may use <p> instead.

  • You can use unordered list<ul> to wrap the inner part of the component . In each <li> should be <img> and <p>.

  • The alternate of the avatar image should not be me, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view does not really need to be in the HTML . You can use CSS for it.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Aside these, great job on this one. Hopefully this feedback helps.

  0