NFT card

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Rodrigo León,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • The HTML needs a little refactoring.

  • In this challenge, you can not use <section> tag the way you did as it’s all one component. According to MDN , <section> is a generic sectioning element that is used whenever it doesn’t make sense to use the other more semantic ones.It is a container that stores self-contained content that still makes sense when placed in a different context. If you are only using the element as a styling wrapper, use a <div>. Also remove <header> landmark , I suggest to look up on HTML elements and their usages.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in icon-clock, icon-ethereum.

  • Profile images like that avatar are valuable content. The alternate text should not be # .You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the class=”divider”, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  Hopefully this feedback helps.

  0

  ---

  

  Rodrigo León•40

  @ReyesRo10Posted about 2 years ago

  @PhoenixDev22 thanks for the feedback! very appreciated

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Rodrigo, congratulations for your new solution!

  Here's some suggestions you can consider to apply to your solution:

  For the container there's no need to use height here, because since you set a height for an element, this means that this element will grow until a certain point and after that the inner content (as texts or images) will start to pop out the element due its fixed height, so isn't necessary to set the height the container height comes from the elements, its paddings and height.

  Its good to add a transition like transition: ease 0.5s to make smooth the hover effect.

  ✌️ I hope this helps you and happy coding!

  0