Skip to content
Submitted almost 3 years ago

NFT Card

Aliza Aziz•30
@Aliza02
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

If you have any suggestions, feel free to deliver. I would appreciate any improvement suggestion

Community feedback

  • Naveen Gumaste•10,480
    @NaveenGumastePosted almost 3 years ago

    Hello Aliza Aziz ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    • Warp your card content around the main tag Ex: 👇
    <body>
<main class="container">
*all you content here*
</main>
</body>

    Check my article on accessibility issues

    • Always use the "alt attribute" and write what img is , and if the img is for decorative then leave it empty but always add it with alt.

    • I think you modified the base color that is given in style-guide.md which is wrong do not do that rather than that do in when you address it in you styling it for individual component

    happy Coding😀

    Marked as helpful
    0
  • Ryan Barnes•250
    @barnesPosted almost 3 years ago

    Looks good, as @Old1337 stated, go through the accessibility report on your submission and step through each of the issues. I enjoy using a frontend framework like Svelte, as alongside of their VS Code Plugins, I get warnings and errors related to these kinds of issues before I deploy. Take a look at my solution if you're curious about using something like Svelte.

    Marked as helpful
    0
  • Account deleted

    Hello there! 👋

    Congratulations on finishing your challenge! 🎉

    I have some feedback on this solution:

    • Always Use Semantic HTML instead of div like <main> <header> <footer> , etc for more info

    • All Images must have alternate text

    i hope this is helpful and goodluck!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord