Submitted over 2 years ago

NFT Card

Guillermo Ochoa• 40

@GuillermoOM

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

NFT preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Anosha Ahmed• 9,300

@anoshaahmed

Posted over 2 years ago

Hey good job on this challenge! Your report above shows a few issues. You can fix them by

wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here
have at least one <h1> in your code

Marked as helpful

Guillermo Ochoa• 40

@GuillermoOM

Posted over 2 years ago

@anoshaahmed Thank you!

I applied your fixes and the report indicates everything to be fine now.

Web Wizard• 5,690

@rsrclab

Posted over 2 years ago

Hi, @GuillermoOM ~

Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

Here are some of the tips I like to provide.

Please try BEM for naming element classes. It will help you a lot on bigger projects.

https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

Cheers ~

Marked as helpful

Guillermo Ochoa• 40

@GuillermoOM

Posted over 2 years ago

@tymren608 Thank you, likewise with yours!

Also, thanks for your input on the BEM theory, will def try to implement it on my future challenges and projects.

Also, I found your HTML to be quite well structured, good job on that

TMJ• 120

@TMJSMC53

Posted over 2 years ago

Good job, Guillermo

Guillermo Ochoa• 40

@GuillermoOM

Posted over 2 years ago

@TMJSMC53 Thank you!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord