NFT card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Gabriel, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • css stylesheet and image are broken because the url is wrong, fix it like this: <link rel="stylesheet" href="https://gabriel-brunetto.github.io/nft-card.github.io/reset.css"> and <img alt="image-block-etherium" class="block-eth" src="images/image-equilibrium.jpg">
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • remove all margin from main class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  0
• 

  Aziz Najjar•240

  @Njoura7Posted over 2 years ago

  Hello mate, you need to refresh your gitHub images and then repost your url solution again :)

  0