NFT Card page, using Flex and vh measurements + hover states

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • The section element is not meant to use here, because it cannot define landmark of a webpage

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <section> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Hina Hotak•190

  @Hna456Posted over 1 year ago

  For the creation part u can make the whole sentence a p element and then wrap the name part inside of a span element and then design it.

  <p> Created by <span class = '..'> Name </span> Now u can target the span class name for css and design it by adding hover effect. Hope so it works and be useful for u.

  0

  ---

  

  Matthew Robinson•40

  @Mattrob10Posted over 1 year ago

  @Hna456

  Thanks I just overlooked the active file for implementation.

  0