Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Gsemyong, great work on this challenge! π
Here are a few tips for improve your code:
- add in the
head
of document thetitle
of page - add
header
tag and wrap the top bar for improve the Accessibility - add
main
tag and wrap the cards for improve the Accessibility - add descriptive text in the
alt
attribute of the image - if you want to use the title for the
href
attribute you have to parse it inurl
, it can give problems creating links with empty spaces or special characters - I would also add a query reset button, I find it very convenient
Overall you did well π Hope this help!
0 - add in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord