Really nice solution!
A few pointers
- use the aria-current="page" attribute to indicate the active page in navigation. You can use this as a styling hook as well if you like
- The focus issue is caused wherever you've included overflow-y hidden. If you set overflow to be hidden on all axis it fixes it. Not sure what's causing this though. It might be a Firefox bug - there was a similar one years ago from what I remember... Or it might be related to animations
- make sure all animations are OFF for people who prefer-reduced-motion
- wrap the footer navigation in a nav element, and make sure it has an aria-label like "footer"
- There's a functional error where you can add a minus number of products to cart
- There's a problem with your focus trap on the modal. Once in it, there is no way for a screenreader user to exit. It needs an explicit close/cancel button so people don't get trapped in there
- The other issue with the modal is that when you click the cart button with a screenreader, it immediately reads out everything in that modal in a really confusing manner
- The other screenreader issue is the multiple "See product" buttons. They need associating with the product name via something like aria-describedby.
That should be enough feedback for now :) Well done, you've worked hard on this and covered loads!!
Marked as helpful
@mbart13
Posted
@grace-snow thanks, you're the best!