Newspaper Sign Up using Vanilla JS

Community feedback

• 

  Krushna Sinnarkar•1,100

  @krushnasinnarkarPosted 4 months ago

  Hi @laibak24,

  Congratulations on successfully completing the challenge!

  Your solution looks nice, though there are a couple of things you can improve, which I hope will be helpful:

  1. Email Validation: Your email validator isn't working properly as it doesn't check for a dot followed by letters. For example, when I entered "test@gmail", it was accepted as a valid email. You should use the following regex pattern to ensure proper validation:

     /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+\.[a-zA-Z]{2,}$/
     

     This pattern will ensure that there's a dot followed by at least two letters.

  2. UI Improvements: Work on your UI to make it more closely match the design. Aim for perfection in layout, spacing, and styling.

  3. Simplifying Layers: There was no need to add multiple layers for the background. You can directly give the background color #242742 to the body and center your .content inside the body.

  I hope you find these suggestions helpful.

  Feel free to reach out if you have more questions or need further assistance.

  Happy coding!

  0