NewsPage

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted over 1 year ago

  hey 😄pineapplegoose, congratulations on completing the challenge... here are a few tips to make your site better.

  1.Regarding the mobile version the image is overflowing... causing the site to have a horizontal scroll make sure the image doesn't have any unnecessary height and width on the mobile version...

  2.When I open the mobile-menu the background color of the site is being changed.. instead of that add an overlay in the background to make it look more beautiful.

  3.And make sure to center all the content (divs) on the mobile-version..

  Hope that helps happy coding💯😄👍🏻

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • The solution generates accessibility error reports due to skipping alt attribute for images

  ---

  • Decorative images don’t add information to the content of a page.

  ---

  • For example, the information provided by the image might already be given using adjacent text, or the image might be included to make the website more visually attractive.

  ---

  • In these cases, a null (empty) alt text should be provided (alt="")

  ---

  • So that they can be ignored by assistive technologies, such as screen readers.

  ---

  I hope you find this useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0