Newsletter-signup Vanilla CSS

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="form"> to a <main class="form">
  • Indeed, the dismiss button should return you to the previous page
  • The path of your favicon is incorrect
  • You use cursor: grab on your buttons, this makes it feel like the button can be grabbed or dragged, which is confusing. You should leave it at its default value or use cursor: pointer

  Marked as helpful

  0

  ---

  

  Michael Johnson•970

  @mikej321Posted 10 months ago

  @Blackpachamame

  Thanks so much for your feedback! For clarification, I don't understand what you mean by the favicon path. I feel like I'm about to learn something new because I've always seen the favicon icons in the project folders but I've never known what they are.

  With the cursor: grab, in the active states, they had a white glove on hover but I couldn't replicate it? Any suggestions or articles?

  Thanks so much!

  Michael

  0

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  @mikej321 The favicon is that small icon that appears in the tabs of each page. And what I mean is that the path you put in the head is wrong: <link rel="icon" type="image/png" sizes="32x32" href="./assets/images/favicon -32x32.png">

  About the cursor, I assume you are referring to the little hand that appears in the design images. If that's the case, then ignore it, it's not something you have to replicate.

  0