@antoebtfr
Posted
Great job ! 👍
- Missing the
cursor: pointeron the subscribe button - [email protected] is static in the success modal. Try to set it dynamically. Ask me if you need help
Answering questions
- Depends of the project and of the situation
- In the project architecture or in a CSS file ?
Architecture :
Depends of the structure, frameworks, CMS used but essentially you regroup them in style folder with different files like style/main.css, style/card.css
Ex : https://github.com/antoebtfr/fM_TODO_list/tree/master/styles
File :
No organisation needed, it's not like scss. Just try to not duplicate the selector like .news-container at line 34 and the same .news-container at line 356 so try to search ( with the command ) in the file if there is no selector yet. If there is media queries in the file try to place them at the end but it's not a "rule"
3.Make it obvious, and use kebab-case
It triggers me so much to see the "Challenge by" like this. So ugly😂
@shinhosuck
Posted
@antoebtfr Thank you very much. Are you saying do not include "Challenge by" or place it some where else? Yeah, the email is not dynamic. I just realized that. Thank you again.
@shinhosuck
Posted
@antoebtfr I fixed the dynamic email issue. Can you see please. Also, I added redirect to index.html/signup page, if the user tries to skip the signup and go directly to success page. Thank you again.
@antoebtfr
Posted
@shinhosuck
Nice job ! and great idea to add the redirect on success.html
Try to disable the outline when you press 'Enter' on the input with a wrong email format
This regex is better because it check the format [fezjofijz454]@[4564ezfz].[ezfjez]
Link to regex : /^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:.[a-zA-Z0-9-]+)$/;
All fine after you correct this 😁👍
@shinhosuck
Posted
@antoebtfr thanks
@shinhosuck
Posted
@antoebtfr How are you Antonain? Can I asked you a favorite? Currently I'm working on a e-commerce website and I'm looking for someone to browse through my site and give me some feedback. Man I try to get some feedback from reddit r/webdev and r/web-design, but no avail. Did not get any feedback. Can you give me some feedback when you have some time. I'm asking you because I like the way critique. Any feedback will be greatly appreciated. Thank you very much. Here is the site: https://aiaimarket.pythonanywhere.com/
You can you - username:test_user, password:NewUser123 or create new account.
