newsletter-sign-up

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 1 year ago

  Hey there, Schismond! 👋

  Nice effort on this challenge! 👏

  A few suggestions I have are,

  • Taking another look at the responsiveness of your site. At the moment, things start to look a little broken/get cut off around ~1000px as the screen width decreases. Remember that even if the desktop and/or mobile views of your site look good, it is important to make sure that your site looks great across all screen sizes so that as many people as possible can enjoy your work. If you’d like to learn more about how building responsive layouts, check out this helpful course
  • Avoiding using px for setting the values of things like font-size and spacings in your styles. Instead, use a responsive unit such as em or rem so that users will be able to change the size of the text (and ideally, overall layout) of your site by changing the default font-size of their browser. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video

  Don't worry too much about making "pixel-perfect" solutions—it's more important to focus on things like accessibility and responsiveness so that people can use and enjoy the websites you make 😉 As long as your solution looks more or less like the design in the end and it is functional and accessible, that's great 👍

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Schismond•160

  @SchismondPosted about 1 year ago

  @ApplePieGiraffe thanks for your comment this was really helpful, I really needed someone to clarify things for me , I will take a look on the resources you included

  Thanks again for your comment I really appreciate it , have a good day

  1