Newsletter sign-up-form with success message

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 10 months ago

  Your site looks pretty good. Some things I noticed when testing your site:

  • the "Dismiss" button from the success message doesn't work
  • the form accepts emails that look like "asdadasda@" even though it shouldn't
  • text box doesn't turn red when error with email occurs

  Proposed solutions:

  • implement "Dismiss" button (you already have the code set up to do so)
  • use regex to test email:
    • const validEmailFormat = /^[^\s@]+@[^\s@]+.[^\s@]+$/
    • var emailEntered = document.getElementById("emailEntry"); if(validEmailFormat.test(emailEntered.value)){ ...
  • alter border color, background color and text color of text field

  Hope this helps 👍

  Marked as helpful

  1