Newsletter sign-up with-success-message

Community feedback

• 

  Yefree Valdez•840

  @yefreescodingPosted over 1 year ago

  Great job! Some things I've noticed in your code that you could fix, and make your project more semantic, accesible and easy to read.

  1. I think there's a problem with the root of the image that goes to the right of the form. Because isn't showing on any browser that I've tested.
  2. Replace the <div></div> element, that you're using as a container for your component, with <main></main>. This will make your code more semantic. Also change use the <section></section> tag instead of <div>.
  3. A <ul></ul> would be better to showcase the info that is meant to be displayed as a list, instead of a <table></table>, also you'll save a couple lines of code.
  4. Using flexbox and grid will help you a lot, to position elements on your website. Believe me it's going to be a game changer for your front end skills.
  5. Build mobile-first. This ensures that the application is responsive and adapts smoothly to larger screens like tablets and desktops, helps you reduce the initial load time, and remember mobile devices are now the primary means of internet access for many users, and this trend is only expected to grow. Overall you're doing a great job. Keep it up!!

  Marked as helpful

  1

  ---

  

  Sara•440

  @saranatour1Posted over 1 year ago

  Thank you for the notes! I do have the in mind and working on them, I also noticed the source image issue and I'll fix it as well, I did exactly like your 5th note! I made it a mobile first then went to the higher resolution,
  I'm trying things out at the moment to learn more and work with any front end frame work or library.
  Thank you again for you remarks! @yefreescoding

  0