Newsletter Signup with CSS styling and JS

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 10 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.

  CSS and Styling:

  • Use the list-style-image rule on the <ul> to use the SVG as list decoration. This will help you avoid having the SVG in the content of the <li>. You can read more about list-style-image here
  • Implement CSS custom properties to define and utilize project colors more easily.
  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  0