Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Newsletter sign-up using react

@thentrsfs

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello guys i did this by using react and i would like to get some review because i know its pretty messy and bad and i would like to see what mistakes did i made, thanks in advance.

Community feedback

@greenMakaroni

Posted

The only thing I would improve is to center the newsletter sign-up by settings its parent element to: width: 100vw; height: 100vh; display: flex; justify-content: center; align-items: center; Also, not sure that router is necessary in this project, its nice to know it, but you could just render components based on state, its better to get into a habit of not installing dependencies that you don't really need, its just extra overhead.

Your submission is very good, much better than mine. :D

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord