Newsletter signup

Community feedback

• 

  P

  cepoumian•120

  @cepoumianPosted 26 days ago

  Hi Daniel. Good job. I few suggestions:

  • Set an event listener for "DOMContentLoaded" in your script. Check docs (https://developer.mozilla.org/en-US/docs/Web/API/Document/DOMContentLoaded_event)
  • Try modularizing your JS code and possibly leveraging web components instead of relying on a monolithic script.
  • Pay more attention to formatting and consistency, specially in CSS stylesheets.
  • Try to match text colors and sizes closer to the design, specially for the body copy, it looks lighter.
  • Make your image responsive. You can use the picture and source tags like this: <picture> <source srcset="/assets/images/illustration-sign-up-mobile.svg" media="(max-width: 697px)" /> <img src="/assets/images/illustration-sign-up-desktop.svg" alt="Illustration" class="bg-image" /> </picture>

  Kind regards and good luck!

  0