Design comparison
SolutionDesign
Solution retrospective
Please tell me how to improve my code...
Community feedback
- @pbryan9Posted 11 months ago
I think it's pretty solid, nice work!
I came up with just a couple small notes:
- I'd say some of the sizing is a little bit off compared to the design (see for example the font size on the input and the padding on the desktop success message).
- The validation is good but I might argue it's a bit too eager - you might consider triggering input validation on blur / submit...as it's currently written, it goes into error mode with the first character typed.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord