Design comparison
Solution retrospective
Little nice component testing up your basic and pre-intermediate skills. It was so fun. I used css and vanilla js in order to add on little bit functionality. Ultimate solution made me really satisfied.
Dear friends , I am looking forward to see your lovely opinions. Please enlighten me , if you have suggestion or else
Community feedback
- @FluffyKasPosted over 1 year ago
Heyo, that looks really nice! Only a few small issues:
-
It would be a nice touch, if the email address that the user typed in would show up in the success modal, instead of that hard-coded email.
-
Right now, you're using an h3 instead of a label element. Each input should come with a label element, like so:
<label for="email">Email address</label> <input type="email" name="email" id="email" />
- As to the input field itself, if you'd like to help to give your users a clue what they should be typing in, you could use a placeholder instead of a value that they have to delete before they start to type.
Other than these, I think you did great, good job!
Marked as helpful0@toronado93Posted over 1 year ago@FluffyKas Hi, Thank you very much for your opinion and suggestions. I immediately updated my code according to your advice.
Have a lovely day :))
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord