Newsletter sign-up form with success message (Vanilla-js)

Community feedback

• 

  Grego•1,310

  @Grego14Posted 7 months ago

  Hello! congratulations on completing the challenge!

  My only recommendation is that you take a look at this element, since with it you will not need to use JavaScript to change the src of the image. <picture>.

  I hope this helps!

  Marked as helpful

  1

  ---

  

  Lucky Avbunufe•190

  @StanmancerPosted 7 months ago

  @Grego14

  Thanks for the feedback. This will help me a lot in the future.

  0
• 

  Sivaprasath•2,520

  @sivaprasath2004Posted 7 months ago

  Hello, I would like to extend my congratulations on completing this challenge.

  • I'm glad to appreciate your code neat and readable. Maintaining clean and understandable code is essential for its long-term usability and efficiency.
  • In your solution, there may be an issue with images sticking at the top layer on the mobile site. I have faced this problem before, and I have a solution.

  @media  (max-width:500px) {
  #main{
      height: 100vh;
      overflow-y: scroll;
  }
  }
  

  • HTML you are using form <input /> tag that was not proper check Example: 123@gma this is can be allow 'Thank you form'.Please use Javascript to check make sure that will be proper work .
  • Alert Message valid email address that is not alerting your sollution.

  #form  #alert-input {
      background-color: #fee2e2;
      border: 2px solid #ff6257;
  }
  

  • Author name and challenge completed content you will be used <div class="attribution" > this is will be not proper in mobile site bottom:5px; use <footer><div class="attribution"></div></footer> use this footer tag that will be fixed in end of the page content .

  Marked as helpful

  0