Frontend Mentor | Newsletter sign-up form with success message coding challenge solution

Solution retrospective

What are you most proud of, and what would you do differently next time?

Hello beautiful 🤗,

This is my solution for this challenge. I'd be happy if you could have a look at my solution and give me some feedback on work to improve it 🫶 🌻

Have a nice day 🌹

Thank you!

What challenges did you encounter, and how did you overcome them?

I had a little issue with CSS syntax at the beginning which caused my page not to load correctly

I had to double-check my codings several times which was painful

What specific areas of your project would you like help with?

I'd like to add some animation to make it have a smooth transition

Community feedback

@0xabdulkhaliq

Posted 5 months ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have a suggestion regarding your code that I believe will be of great interest to you.

PROPERLY LINKING LABELS 🔖:

input elements wants a label associated with it in a proper way, adding a label without proper association with it's input element does not work.

Currently you only added id attribute for input element but you forget to add name attribute.

Theid of a input element has nothing to do with the data contained within the element. IDs are for hooking the element with JavaScript and CSS.

The name attribute is used when sending data in a form submission. Different controls respond differently. For example, you may have several radio buttons with different id attributes, but the same name. When submitted, there is just the one value in the response - the radio button you selected.

So please add name attribute of email for input element to link the label properly.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Thu Nguyen• 240

@NgocMinhThuNguyen

Posted 5 months ago

Hi, @0xabdulkhalid Thank you for your feedback! 🌹

Yes, I forgot to add the name attribute of the email for input. I fixed it already

Thanks again for your help 🤗

Newsletter sign-up form with success message