Submitted over 1 year ago
Newsletter sign-up form with success message using Flexbox, Grid
@Terminal239
Design comparison
SolutionDesign
Solution retrospective
Please provide feedback on code and design. Thank you!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- The
input
field of mail want to add style rules after adding theall: unset
rule - This rule ensure to remove all the default styling of the input element so that in every devices your
input
element will looks as per you designed - So don't forget to add
all: unset
style rule on top other styles, an example below
.input-email { all: unset; --- Then your styles --- }
- And another tip; use
outline
instead ofborder
. Becauseborder
will consume extra space whileoutline
doesn't
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @NehalSahu8055Posted over 1 year ago
Hello Coder π.
Congratulations on successfully completing the challenge! π
- Instead of using these attributes use them in the body and replace
place-content
withplace-items
main { background-color: var(--neutral-dark-slate-grey); background-size: cover; display: grid; place-content: center; }
like this
body { background-color: var(--neutral-dark-slate-grey); background-size: cover; display: grid; place-items: center; }
- Do this and see the effect.
I hope you find this helpful. Above all, the solution you submitted is great!
Happy codingπ
0@Terminal239Posted over 1 year ago@NehalSahu8055 Thank you for the advice, but using the
place-items
property places the container at the start and not in the middle which is the requirement for the design.0 - Instead of using these attributes use them in the body and replace
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord