Newsletter sign-up form with success message

Community feedback

• 

  Yefree Valdez•840

  @yefreescodingPosted over 1 year ago

  You solution looks great! Just a couple of things to take into account to make your code more readable, semantic, and accesible.

  1. Replace the <div class="container"> elements, with <main class="container"> and <section class="text"> elements to improve semantic structure.
  2. Change this <div class="btn"> Dismiss message</div> for a actual <button type="button" class="btn"> Dismiss message</button>. Using the tag button makes more sense.
  3. <li><img src="images/icon-list.svg" alt=""> Don't forget to add the alt attribute to the every image in your document with a proper description.
  4. You should use css styles instead of the <br/> tag, to create line breaks, or make an element become a block: <br> <span> </span> please open it and click <br>
     <span style="display:block:"> </span> please open it and click . Hope this could help you become a better front end developer. Keep it up!!

  Marked as helpful

  0

  ---

  

  Bavly Albeir•50

  @BavlyAlbeirPosted over 1 year ago

  Thank you very much for the tips @yefreescoding I will use it to improve my code

  0