Newsletter sign-up form with success message solution
Design comparison
Solution retrospective
I want to know where should I edit my JS code ? FIX <BODY> tag is completed.
Community feedback
- @itushPosted over 1 year ago
π Congratulations on completing the challenge! Great job! π
Your solution looks nice. However, I'd like to point out a few suggestions to make it even better. π€
- It looks like you forgot to close the </body> tag in your HTML.
- β‘οΈ While it's alright to link a JavaScript file in the head element with the defer attribute, it's best practice to link JavaScript files at the end of the body. This ensures that HTML parsing is complete before JavaScript execution. If you need to execute JavaScript code earlier, defer is a good option.
- You may safely remove the email validation script from the body below the footer and it should work.
Once again, you have done a wonderful job! π
I look forward to seeing more cool projects from you in the futureπ
Keep up the great work and happy hacking! π»
1@murphy6867Posted over 1 year ago@itush I'm so appreciative of your comment. You reminded me of a lot of things that I had overlooked π. Thank you for cheering me up, and I will try my best to improve my front-end skills. ππ»
1 - @LifeofPaksPosted over 1 year ago
Look really good. π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord