Newsletter sign-up form with success message solution
Design comparison
Solution retrospective
any suggestion to improve my code is welcome :D
Community feedback
- @clinto-beanPosted over 1 year ago
Hey Jordan, great work. The only thing I can recommend is to avoid using the min-height: 100vh on the body, because when viewing this on my laptop (1920x1080 @ 13"), it is vertically overflowing causing scrolling that isn't necessary.
You can either attempt to size the main body by adding padding to the container and its children, or you can use a unit like dvw rather than vw, as dvw is a dynamic viewport unit that takes into account things like the UI elements of a user's browser.
0@jordanhevePosted over 1 year agoap@clintonclark1995 Hi, I appreciate your feedback. How does the overflowing occur on your laptop? I checked this on mine with the same dimensions and it didn't happen, except when I had the Windows display screen set to a value above 150%. In that case, I couldn't find a solution to avoid the overflow, other than zooming out in the browser, I supposed the rem dimensions of the other elements determine the space to be occupied within the container regardless of the dimensions of the body causing the overflow in some screens, so i dont know what to do in that case, dvh didnt work
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord