Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Newsletter sign-up form with success message

@Hamza0053

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This challange was great! By solving this==> I have experience of using picture tag first time. I also use email validation proccess through javascript that was good experience for me. I you have any suggestion for me please drop there. All feedbacks are welcome.

Community feedback

@Blackpachamame

Posted

Greetings Hamza! let me tell you, you've done a great job here.

I can mention the following:

  • A form input element has neither an id nor a name attribute. This might prevent the browser from correctly autofilling the form. More info
  • El elemento label no tiene el atributo for para enlazarlo correctamente con el input
  • Haz colocado display: block en los estilos en línea de tu img y al mismo tiempo en tus estilos CSS. Recomiendo eliminar esos estilos en línea

The rest looks very correct 😃

0

@Hamza0053

Posted

@Blackpachamame Thanks for feedback you use some work other than English sorry but I cannot understand them

0

@Blackpachamame

Posted

@Hamza0053 Oh! I'm sorry I forgot to translate from Spanish lol

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord